Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFBUGS-980: Revert "csi: disable fencing in Rook" #798

Conversation

subhamkrai
Copy link

This reverts commit d4f86a0.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2024
@sunilheggodu sunilheggodu changed the title Revert "csi: disable fencing in Rook" DFBUGS-980: Revert "csi: disable fencing in Rook" Dec 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2024

@subhamkrai: This pull request references [Jira Issue DFBUGS-980](https://issues.redhat.com//browse/DFBUGS-980), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.14.13) matches configured target version for branch (odf-4.14.13)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

This reverts commit d4f86a0.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sp98
Copy link

sp98 commented Dec 19, 2024

lgtm

@sp98
Copy link

sp98 commented Dec 19, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
Copy link

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp98, subhamkrai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sp98 sp98 merged commit 88ffd7b into red-hat-storage:release-4.14 Dec 19, 2024
15 of 46 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2024

@subhamkrai: [Jira Issue DFBUGS-980](https://issues.redhat.com//browse/DFBUGS-980): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-980](https://issues.redhat.com//browse/DFBUGS-980) has been moved to the MODIFIED state.

In response to this:

This reverts commit d4f86a0.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug jira/valid-reference lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants