Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFBUGS-1028: csi-snapshotter flag typo; upgrade csi-snapshotter #799

Merged

Conversation

Madhu-1
Copy link
Member

@Madhu-1 Madhu-1 commented Jan 2, 2025

This is backport of rook#15196 to 4.18

Signed-off-by: Steven Kreitzer [email protected]
(cherry picked from commit 463d9fb)

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Signed-off-by: Steven Kreitzer <[email protected]>
(cherry picked from commit 463d9fb)
@Madhu-1 Madhu-1 changed the title csi: csi-snapshotter flag typo; upgrade csi-snapshotter DFBUGS-1028: csi-snapshotter flag typo; upgrade csi-snapshotter Jan 2, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Jan 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 2, 2025

@Madhu-1: This pull request references [Jira Issue DFBUGS-1028](https://issues.redhat.com//browse/DFBUGS-1028), which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is backport of rook#15196 to 4.18

Signed-off-by: Steven Kreitzer [email protected]
(cherry picked from commit 463d9fb)

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Madhu-1
Copy link
Member Author

Madhu-1 commented Jan 2, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug and removed jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Jan 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 2, 2025

@Madhu-1: This pull request references [Jira Issue DFBUGS-1028](https://issues.redhat.com//browse/DFBUGS-1028), which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

@subhamkrai subhamkrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2025
@subhamkrai subhamkrai added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2025
Copy link

openshift-ci bot commented Jan 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Madhu-1, subhamkrai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit df7a68d into red-hat-storage:release-4.18 Jan 2, 2025
52 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 2, 2025

@Madhu-1: [Jira Issue DFBUGS-1028](https://issues.redhat.com//browse/DFBUGS-1028): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-1028](https://issues.redhat.com//browse/DFBUGS-1028) has been moved to the MODIFIED state.

In response to this:

This is backport of rook#15196 to 4.18

Signed-off-by: Steven Kreitzer [email protected]
(cherry picked from commit 463d9fb)

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug jira/valid-reference lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants