csv: use ROOK_CSI_ENABLE_CEPHFS in rook operator env #803
Conversation
use the value from ocs operator config by using the calue from operator env ROOK_CSI_ENABLE_CEPHFS Signed-off-by: parth-gr <[email protected]>
| valueFrom: | ||
| configMapKeyRef: | ||
| key: ROOK_CSI_ENABLE_CEPHFS | ||
| name: ocs-operator-config |
There was a problem hiding this comment.
It seems odd to mount the ocs operator config to the rook operator. Instead of mounting that configmap, what if we just set the env value directly to enabled it by default? Then the user can override it with the configmap that rook already checks.
- name: ROOK_CSI_ENABLE_CEPHFS
value: "true"There was a problem hiding this comment.
So in the case of ocs-operator deploying rook, how user automation can set the value in the rook cm?
We thought of adding it in the ocs operator configmap and then to the rook operator deployment env varibles
There was a problem hiding this comment.
The same pattern we follow for ROOK_CURRENT_NAMESPACE_ONLY
There was a problem hiding this comment.
Ok, thanks for the discussion, I see now that this is needed to pick up the downstream settings from ocs operator, and follows the same pattern of some other settings.
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@iamniting: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: iamniting, parth-gr, travisn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.18 |
|
@parth-gr: new pull request created: #804 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
use the value from ocs operator config by
using the calue from operator env ROOK_CSI_ENABLE_CEPHFS
refer: red-hat-storage/ocs-operator#2970
Checklist: