Skip to content

Add RHDH skills volume support to LCORE container - #349

Closed
yangcao77 wants to merge 1 commit into
redhat-ai-dev:developmentfrom
yangcao77:skills-support
Closed

Add RHDH skills volume support to LCORE container#349
yangcao77 wants to merge 1 commit into
redhat-ai-dev:developmentfrom
yangcao77:skills-support

Conversation

@yangcao77

Copy link
Copy Markdown

What does this PR do?

PR title

Add RHDH skills volume support to LCORE

Summary

  • Adds an emptyDir volume for RHDH skills.
  • Uses an init container with quay.io/redhat-ai-dev/utils:latest to fetch the main branch of redhat-developer/rhdh-skills.
  • Copies the repository’s skills/ contents into the shared volume.
  • Mounts the volume at /app-root/skills in lightspeed-core.
  • Keeps the mount writable so skill scripts can create or modify files when required.
  • Makes the PostSync patch idempotent across repeated Argo CD syncs.
  • Adds CI coverage for initial deployment and repeated synchronization.

Testing

  • bash tests/helm/test-skills-volume.sh
  • helm lint charts/rhdh --set okp.enabled=false
  • ShellCheck
  • git diff --check

No new LCORE image or long-running sidecar is introduced.

Which issue(s) does this PR fix

https://redhat.atlassian.net/browse/RHIDP-16676

How to test changes / Special notes to the reviewer

Signed-off-by: Stephanie <yangcao@redhat.com>
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@yangcao77

Copy link
Copy Markdown
Author

closing this PR and reopen #351 from remote branch to trigger the CI

@yangcao77 yangcao77 closed this Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant