[RHIDP-12414] Fix file-id leaking into query response - #3
Merged
Merged
Conversation
…to response Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Contributor
|
Just a question @Jdubrick would this address the reference error? My understanding was that this |
JslYoon
approved these changes
Mar 6, 2026
Contributor
Author
|
Which reference error are you talking about @JslYoon? This PR fixes the reported issue here: https://redhat-internal.slack.com/archives/C081KVDV6LV/p1771989582617069?thread_ts=1771367096.585949&cid=C081KVDV6LV where its citing sources it used during the RAG tool calls, but incorrectly uses the internal file id because the default prompt template in Llama Stack is This updates that so these internal file ids don't get "cited" in the response |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
<| file -id xyz |>that was making its way into our responses.Which issue(s) this PR fixes:
https://issues.redhat.com/browse/RHIDP-12414
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.
Tested and Verified
Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)
How to test changes / Special notes to the reviewer: