Skip to content

[RHIDP-12531] Add CI Tests - #5

Merged
Jdubrick merged 4 commits into
redhat-ai-dev:mainfrom
Jdubrick:add-ci-tests
Mar 16, 2026
Merged

[RHIDP-12531] Add CI Tests#5
Jdubrick merged 4 commits into
redhat-ai-dev:mainfrom
Jdubrick:add-ci-tests

Conversation

@Jdubrick

@Jdubrick Jdubrick commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?:

  • Adds basic tests to ensure the containers start with the configs stored in this repository

Which issue(s) this PR fixes:

https://issues.redhat.com/browse/RHIDP-12531

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.

  • Tested and Verified

  • Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)

How to test changes / Special notes to the reviewer:

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
@Jdubrick
Jdubrick marked this pull request as draft March 10, 2026 21:51
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
@Jdubrick
Jdubrick marked this pull request as ready for review March 12, 2026 15:37
@Jdubrick

Copy link
Copy Markdown
Contributor Author

FYI @thepetk , I moved to the midstream image instead of the registry one (same image, just one isnt Konflux built) so we can test on the PR. If it needs a token it won't inject those tokens on PRs from forks

@thepetk thepetk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jdubrick lgtm, before approving a qq: do you have a test run somewhere which you can share just to verify that everything looks good?

@Jdubrick

Copy link
Copy Markdown
Contributor Author

@Jdubrick lgtm, before approving a qq: do you have a test run somewhere which you can share just to verify that everything looks good?

They ran as part of this PR actually: https://github.com/redhat-ai-dev/lightspeed-configs/actions/runs/23010067800/job/66818403993?pr=5

@thepetk

thepetk commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

@Jdubrick lgtm, before approving a qq: do you have a test run somewhere which you can share just to verify that everything looks good?

They ran as part of this PR actually: https://github.com/redhat-ai-dev/lightspeed-configs/actions/runs/23010067800/job/66818403993?pr=5

lol I didn't notice, sry :D

@Jdubrick
Jdubrick merged commit 4c54c09 into redhat-ai-dev:main Mar 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants