Skip to content

Add skills support - #52

Merged
yangcao77 merged 3 commits into
redhat-ai-dev:mainfrom
yangcao77:skills-config
Aug 17, 2026
Merged

Add skills support#52
yangcao77 merged 3 commits into
redhat-ai-dev:mainfrom
yangcao77:skills-config

Conversation

@yangcao77

Copy link
Copy Markdown
Contributor

What does this PR do?:

Description:

Summary

  • Add RHDH skills integration: skills config in lightspeed-stack.yaml, compose volume mount, fetch-skills.sh
    script, and make get-skills target

Test plan

  • make get-skills fetches skills into skills/ directory
  • make local-up starts successfully with skills volume mounted

🤖 Generated with Claude Code

Which issue(s) this PR fixes:

https://redhat.atlassian.net/browse/RHIDP-14224

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.

  • Tested and Verified

  • Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)

How to test changes / Special notes to the reviewer:

make get-skills
make local-up

skills are available under /v1/skills, and also consumable in query

Screenshot 2026-08-14 at 2 47 59 PM Screenshot 2026-08-14 at 2 48 13 PM Screenshot 2026-08-14 at 2 50 28 PM

Signed-off-by: Stephanie <yangcao@redhat.com>
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

The invalid_question_response replacement regex only looked ahead to
^mcp_servers:, so it swallowed the new skills: block (inserted between
invalid_question_response and mcp_servers) and deleted it whenever the
sync script regenerated the file, causing validate-configs to fail.

Co-authored-by: Cursor <cursoragent@cursor.com>
@yangcao77
yangcao77 requested a review from Jdubrick August 14, 2026 19:29

@Jdubrick Jdubrick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes themselves lgtm. Do we want to update CONTRIBUTING.md with the new make command? and do we need to update the gitops sync script in this repo to sync this to the dev environment, or are those follow ups?

Comment thread scripts/fetch-skills.sh
Signed-off-by: Stephanie <yangcao@redhat.com>
@yangcao77

Copy link
Copy Markdown
Contributor Author

Changes themselves lgtm. Do we want to update CONTRIBUTING.md with the new make command? and do we need to update the gitops sync script in this repo to sync this to the dev environment, or are those follow ups?

updated CONTRIBUTING.md.
Re the gitops sync script, no change is needed for generate-gitops-manifests.sh , the skills config value syncs correctly with the current skill.
Actually mounting skill files onto the rolling demo cluster would be a separate repo/follow-up

@yangcao77
yangcao77 requested a review from Jdubrick August 17, 2026 15:02

@Jdubrick Jdubrick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yangcao77
yangcao77 merged commit f1d5a68 into redhat-ai-dev:main Aug 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants