Skip to content

feat: replace RAG with OKP, update vector_store embedding model - #53

Merged
maysunfaisal merged 6 commits into
redhat-ai-dev:mainfrom
maysunfaisal:okp-integration-1
Aug 17, 2026
Merged

feat: replace RAG with OKP, update vector_store embedding model#53
maysunfaisal merged 6 commits into
redhat-ai-dev:mainfrom
maysunfaisal:okp-integration-1

Conversation

@maysunfaisal

@maysunfaisal maysunfaisal commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?:

  • Remove byok_rag section (replaced by OKP)
  • Remove stale TODO comment on annotation_prompt_params
  • Update vector_store embedding model to nomic-ai/nomic-embed-text-v1.5
  • Update vector_store path to /tmp/vector_db/notebooks/faiss_store.db
  • Add rag.tool: [okp] and okp config block at bottom
  • Stripping OKP from config in CI because we cannot realistically run OKP in local CI

Which issue(s) this PR fixes:

https://redhat.atlassian.net/browse/RHIDP-14130

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.

  • Tested and Verified

  • Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)

How to test changes / Special notes to the reviewer:

- Remove byok_rag section (replaced by OKP)
- Remove stale TODO comment on annotation_prompt_params
- Update vector_store embedding model to nomic-ai/nomic-embed-text-v1.5
- Update vector_store path to /tmp/vector_db/notebooks/faiss_store.db
- Add rag.tool: [okp] and okp config block at bottom

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@maysunfaisal

Copy link
Copy Markdown
Contributor Author

Verified

Screenshot 2026-08-14 at 5 49 43 PM Screenshot 2026-08-14 at 5 49 51 PM

maysunfaisal and others added 2 commits August 14, 2026 18:28
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
OKP requires a Solr backend not present in CI docker-compose, causing
LCORE to crash on startup. Use yq to remove rag/okp sections in-place
before compose up, keeping lightspeed-stack.yaml as single source of truth.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@maysunfaisal
maysunfaisal requested a review from Jdubrick August 14, 2026 22:49
maysunfaisal and others added 2 commits August 14, 2026 19:04
Replace broken sed-based BYOK injection with awk pipeline step. The old
sed patterns matched byok_rag content that no longer exists in the source
config. The new inject_byok_rag function inserts only custom-org-docs
BYOK (rhdh-docs replaced by OKP) and adds it to rag.tool alongside okp.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use nomic-ai/nomic-embed-text-v1.5 and /tmp/ path to align with
source lightspeed-stack.yaml vector_store config.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@maysunfaisal

Copy link
Copy Markdown
Contributor Author

generate gitops manifest script looks good after update:

mcp_servers:
  - name: mcp-integration-tools
    provider_id: "model-context-protocol"
    url: "http://localhost:7007/api/mcp-actions/v1"
    authorization_headers:
      Authorization: "client"
byok_rag:
  - rag_id: custom-org-docs
    rag_type: inline::faiss
    embedding_model: nomic-ai/nomic-embed-text-v1.5
    embedding_dimension: 768
    vector_db_id: vs_727b6321-1ff4-47bf-a76b-1cc12426c954
    db_path: /tmp/vector_db/custom_docs/faiss_store.db
    score_multiplier: 1.0
rag:
  tool:
    - custom-org-docs
    - okp
okp:
  rhokp_url: "${env.OKP_SERVICE_URL:=http://localhost:8080}"
  offline: true
  chunk_filter_query: "product:*developer_hub*"

@maysunfaisal

maysunfaisal commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

@Jdubrick I think Rajin's BYOK Vector Store needs to be regenerated for OGX? 🤔

Comment thread scripts/generate-gitops-manifests.sh Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change this to nomic too if we swapped it in the main config

@Jdubrick

Copy link
Copy Markdown
Contributor

@Jdubrick I think Rajin's BYOK Vector Store needs to be regenerated for OGX? 🤔

Yeah most likely if it was created using llama stack instead of the ogx based generator. That can be a separate follow up issue IMO

Align the cluster pgvector rewrite with the main config, which was
swapped to nomic-ai/nomic-embed-text-v1.5. Addresses review feedback
on PR redhat-ai-dev#53.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@maysunfaisal
maysunfaisal requested a review from Jdubrick August 17, 2026 18:24

@Jdubrick Jdubrick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maysunfaisal
maysunfaisal merged commit 8235f4e into redhat-ai-dev:main Aug 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants