feat: replace RAG with OKP, update vector_store embedding model - #53
Merged
Merged
Conversation
- Remove byok_rag section (replaced by OKP) - Remove stale TODO comment on annotation_prompt_params - Update vector_store embedding model to nomic-ai/nomic-embed-text-v1.5 - Update vector_store path to /tmp/vector_db/notebooks/faiss_store.db - Add rag.tool: [okp] and okp config block at bottom Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
Contributor
Author
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
OKP requires a Solr backend not present in CI docker-compose, causing LCORE to crash on startup. Use yq to remove rag/okp sections in-place before compose up, keeping lightspeed-stack.yaml as single source of truth. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace broken sed-based BYOK injection with awk pipeline step. The old sed patterns matched byok_rag content that no longer exists in the source config. The new inject_byok_rag function inserts only custom-org-docs BYOK (rhdh-docs replaced by OKP) and adds it to rag.tool alongside okp. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use nomic-ai/nomic-embed-text-v1.5 and /tmp/ path to align with source lightspeed-stack.yaml vector_store config. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
generate gitops manifest script looks good after update: |
Contributor
Author
|
@Jdubrick I think Rajin's BYOK Vector Store needs to be regenerated for OGX? 🤔 |
Jdubrick
reviewed
Aug 17, 2026
Contributor
There was a problem hiding this comment.
We should change this to nomic too if we swapped it in the main config
Contributor
Yeah most likely if it was created using llama stack instead of the ogx based generator. That can be a separate follow up issue IMO |
Align the cluster pgvector rewrite with the main config, which was swapped to nomic-ai/nomic-embed-text-v1.5. Addresses review feedback on PR redhat-ai-dev#53. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What does this PR do?:
Which issue(s) this PR fixes:
https://redhat.atlassian.net/browse/RHIDP-14130
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.
Tested and Verified
Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)
How to test changes / Special notes to the reviewer: