[RHIDP-12413] Update for Llama Stack v0.5.x - #7
Conversation
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
JslYoon
left a comment
There was a problem hiding this comment.
Is there a reason why we keep both WITH_SAFETY and ENABLE_SAFETY for the safety guard configuration?
|
@JslYoon |
Just was confused by two similar names, perhaps standardizing it could be better? I'm open for both |
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
|
@JslYoon I'm inclined to leave them separately named to help make it clear what is for spinning things up locally vs. used in Llama Stack config for filtering out items. If it gets confusing down the line we can re-assess. wdyt? |
What does this PR do?:
run.yamlto be compatible for Llama Stack v0.5.xrun.yamlandrun-no-guard.yaml, we can use a single file with aENABLE_SAFETYenv var to conditionally add the safety piecescomposefiles and commands for local developmentimages.yamlfor upcoming Sprint for working versions based on Llama Stack v0.5.x.Which issue(s) this PR fixes:
https://redhat.atlassian.net/browse/RHIDP-12413
https://redhat.atlassian.net/browse/RHIDP-12408
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.
Tested and Verified
Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)
How to test changes / Special notes to the reviewer: