Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update container image registry: docker.io -> quay.io #131

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Jan 16, 2025

Ensure configure_ec2 pattern EE does not use DockerHub to pull or host images
The container image has been moved from DockerHub to quay.io

@abikouo abikouo requested review from hakbailey and gravesm January 23, 2025 11:37
@hakbailey
Copy link
Collaborator

When I tried to run this in AAP, I got the following error: image platform (linux/arm64) does not match the expected platform (linux/amd64). I think you may need to ensure you're building the image with the right architecture. I've been doing the following, which works:

ansible-builder create
docker buildx build --platform linux/amd64

@abikouo abikouo requested a review from gravesm January 23, 2025 16:01
@abikouo abikouo merged commit 6da4185 into redhat-cop:main Jan 23, 2025
23 checks passed
Copy link

patchback bot commented Jan 24, 2025

Backport to stable-3: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 6da4185 on top of patchback/backports/stable-3/6da41851632ddab82400e9cb7d965eff9647d04f/pr-131

Backporting merged PR #131 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/redhat-cop/cloud.aws_ops.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-3/6da41851632ddab82400e9cb7d965eff9647d04f/pr-131 upstream/stable-3
  4. Now, cherry-pick PR Update container image registry: docker.io -> quay.io #131 contents into that branch:
    $ git cherry-pick -x 6da41851632ddab82400e9cb7d965eff9647d04f
    If it'll yell at you with something like fatal: Commit 6da41851632ddab82400e9cb7d965eff9647d04f is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 6da41851632ddab82400e9cb7d965eff9647d04f
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Update container image registry: docker.io -> quay.io #131 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-3/6da41851632ddab82400e9cb7d965eff9647d04f/pr-131
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link

patchback bot commented Jan 24, 2025

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/6da41851632ddab82400e9cb7d965eff9647d04f/pr-131

Backported as #147

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 24, 2025
Update container image registry: docker.io -> quay.io

(cherry picked from commit 6da4185)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants