.metadata.name and .spec missing creating RolloutMgr (#6029)
#830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
keithchong
force-pushed
the
6029-UpdateCSVWithArgoRolloutManagerAndRollout
branch
2 times, most recently
from
34d26ad to
42df21c
Compare
|
/retest |
Signed-off-by: Keith Chong <[email protected]>
keithchong
force-pushed
the
6029-UpdateCSVWithArgoRolloutManagerAndRollout
branch
from
42df21c to
652ca99
Compare
|
/test v4.14-kuttl-sequential |
|
Thanks Keith, and thanks @chetan-rns for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
See https://issues.redhat.com/browse/GITOPS-6029
Have you updated the necessary documentation?
No
Which issue(s) this PR fixes:
Fixes #? Fixes https://issues.redhat.com/browse/GITOPS-6029
Test acceptance criteria:
How to test changes / Special notes to the reviewer: