fix(Makefile): Remove duplicate operator-sdk goal, simplify code

[olivergondza]

What type of PR is this?

/kind cleanup

What does this PR do / why we need it:

The goal was duplicate with similar (but not same) logic - eliminated.

The implementation was silently picking operator-sdk when on PATH - must be provided through OPERATOR_SDK now. Element of least astonishment.

Conditional Makefile logic removed leveraging native make features.

Have you updated the necessary documentation?

• [n/a] Documentation update is required by this PR.
• [n/a] Documentation has been updated.

Which issue(s) this PR fixes:

None

Test acceptance criteria:

• [n/a] Unit Test
• [n/a] E2E Test

How to test changes / Special notes to the reviewer:

• make bundle
• rm -rf ./bin && make bundle
• make OPERATOR_SDK=/bin/operator-sdk bundle # When installed locally

[openshift-ci]

Hi @olivergondza. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[olivergondza]

This goal deps are satisfied when user provided existing installation through OPERATOR_SDK, or when they did not, but the file exists in our default location bin/operator-sdk. When neither is the case bin/operator-sdk goal kicks in to perform the install.

[jgwest]

/ok-to-test

[olivergondza]

/retest

[olivergondza]

The tests are passing, this is ready for review.

[olivergondza]

Any comments, objections?

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign svghadi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@olivergondza: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v4.14-kuttl-sequential	684e1ea	link	false	/test v4.14-kuttl-sequential
ci/prow/v4.14-e2e	684e1ea	link	true	/test v4.14-e2e
ci/prow/v4.19-e2e	684e1ea	link	true	/test v4.19-e2e
ci/prow/v4.19-kuttl-sequential	684e1ea	link	true	/test v4.19-kuttl-sequential
ci/prow/v4.19-kuttl-parallel	684e1ea	link	true	/test v4.19-kuttl-parallel
ci/prow/v4.14-kuttl-parallel	684e1ea	link	false	/test v4.14-kuttl-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.