Skip to content

fix: dont trash the document when removing clutter (#818) #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix: dont trash the document when removing clutter (#818) #819

merged 1 commit into from
Jan 28, 2025

Conversation

adietish
Copy link
Collaborator

@adietish adietish commented Jan 27, 2025 •
edited
Loading

fixes #818

@adietish adietish self-assigned this Jan 27, 2025
@adietish adietish changed the title fix: allow to refresh all contexts (#809) fix: dont trash the document when removing clutter (#818) Jan 27, 2025
@adietish adietish force-pushed the issue-818 branch 7 times, most recently from d5dc093 to 7a60e82 Compare January 28, 2025 08:08
@adietish adietish marked this pull request as ready for review January 28, 2025 08:12
@adietish adietish requested a review from sbouchet January 28, 2025 08:21
@adietish adietish force-pushed the issue-818 branch 4 times, most recently from 7fa8eab to f54bc7a Compare January 28, 2025 11:22
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sbouchet
sbouchet approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. editor still shows valid content after removing clutter

@adietish adietish merged commit 92f4e7e into redhat-developer:main Jan 28, 2025
14 checks passed
@adietish adietish deleted the issue-818 branch January 28, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbouchet sbouchet sbouchet approved these changes

Assignees

@adietish adietish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Remove Metadata Clutter" doesn't preseve order of resources, adds namespaces and turns "---" into "------"
2 participants
@adietish @sbouchet