feat: hint ref'd by matchLabels/-Expressions & list them in editor (#642) #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adietish
force-pushed
the
issue-642
branch
16 times, most recently
from
9294831 to
aba2406
Compare
adietish
force-pushed
the
issue-642
branch
8 times, most recently
from
56c98a0 to
ce365fd
Compare
adietish
force-pushed
the
issue-642
branch
4 times, most recently
from
587d481 to
93503a4
Compare
adietish
force-pushed
the
issue-642
branch
13 times, most recently
from
6f18a38 to
c1c2c85
Compare
adietish
changed the title
adietish
force-pushed
the
issue-642
branch
2 times, most recently
from
8ef1541 to
c9b2dd1
Compare
…edhat-developer#642) Signed-off-by: Andre Dietisheim <[email protected]>
adietish
force-pushed
the
issue-642
branch
5 times, most recently
from
a3c0073 to
3a4eaa8
Compare
Freezing was caused by race conditions in the locks. Closing the editor disposes the editor resources. Disposing the editor resource closes the cluster connection. When closing the watch, a new resource state is retrieved, this then ended in the resource lock waiting for the connection timeout. Solved it by introducing a new "Disposed" state which is returned whenever an editor resource is disposed. No further state retrieval occurrs. Signed-off-by: Andre Dietisheim <[email protected]>
adietish
force-pushed
the
issue-642
branch
2 times, most recently
from
d9bd688 to
8b6b043
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #642