Skip to content
This repository was archived by the owner on Apr 23, 2025. It is now read-only.

fix: load/save token in a task, avoid slow operation error (#958) #965

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

adietish
Copy link
Contributor

fixes #958

Copy link

openshift-ci bot commented Jan 29, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@adietish adietish self-assigned this Feb 3, 2025
@adietish adietish force-pushed the issue-958 branch 4 times, most recently from ef7f5c1 to 1e2dfe5 Compare February 5, 2025 11:20
@adietish adietish requested a review from sbouchet February 5, 2025 13:16
@adietish adietish marked this pull request as ready for review February 5, 2025 13:17
@redhat-developer redhat-developer deleted a comment from openshift-ci bot Feb 5, 2025
@redhat-developer redhat-developer deleted a comment from openshift-ci bot Feb 5, 2025
Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't see errors anymore when using devsandbox forthe first time.

Copy link

openshift-ci bot commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbouchet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 6, 2025
@adietish
Copy link
Contributor Author

adietish commented Feb 6, 2025

/override "Integration UI Tests with Local Kind Cluster Context Report"

Copy link

openshift-ci bot commented Feb 6, 2025

@adietish: Overrode contexts on behalf of adietish: Integration UI Tests with Local Kind Cluster Context Report

In response to this:

/override "Integration UI Tests with Local Kind Cluster Context Report"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adietish
Copy link
Contributor Author

adietish commented Feb 6, 2025

/override "ci/prow/e2e-openshift"

Copy link

openshift-ci bot commented Feb 6, 2025

@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift

In response to this:

/override "ci/prow/e2e-openshift"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Feb 6, 2025

New changes are detected. LGTM label has been removed.

@adietish adietish added the lgtm label Feb 6, 2025
@redhat-developer redhat-developer deleted a comment from openshift-ci bot Feb 6, 2025
@adietish
Copy link
Contributor Author

adietish commented Feb 6, 2025

/override "Integration UI Tests with Local Kind Cluster Context Report"

Copy link

openshift-ci bot commented Feb 6, 2025

@adietish: Overrode contexts on behalf of adietish: Integration UI Tests with Local Kind Cluster Context Report

In response to this:

/override "Integration UI Tests with Local Kind Cluster Context Report"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@redhat-developer redhat-developer deleted a comment from openshift-ci bot Feb 6, 2025
@adietish
Copy link
Contributor Author

adietish commented Feb 6, 2025

/override "ci/prow/e2e-openshift"

Copy link

openshift-ci bot commented Feb 6, 2025

@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift

In response to this:

/override "ci/prow/e2e-openshift"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@openshift-merge-bot openshift-merge-bot bot merged commit e3e247a into redhat-developer:main Feb 6, 2025
18 checks passed
@adietish adietish deleted the issue-958 branch February 6, 2025 15:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-cancelable slow operations are prohibited inside read action
2 participants