This repository has been archived by the owner on Nov 11, 2024. It is now read-only.
Don't fail when adding a service to an environment with no pipelines. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
/lgtm |
openshift-ci-robot
added
lgtm
|
/lgtm cancel |
openshift-ci-robot
removed
lgtm
bigkevmcd
force-pushed
the
handle-no-pipelines
branch
2 times, most recently
from
570f307 to
3f10b4a
Compare
bigkevmcd
force-pushed
the
handle-no-pipelines
branch
from
3f10b4a to
a13f5e9
Compare
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
@sbose78 Are you ok to go ahead with this? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wtam2018 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do / why we need it:
Don't fail when you provide a service with an image to an environment with no pipelines
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
#102
How to test changes / Special notes to the reviewer: