Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: manage podman inspect result as a list also #7269

Merged

Conversation

too-common-name
Copy link
Contributor

What type of PR is this:

/kind bug
/area odo-on-podman

What does this PR do / why we need it:

This PR addresses an issue when using the odo commands with Podman, specifically related to the podman pod inspect command. Due to a recent change in Podman (see podman PR #21514), the output now returns a JSON array instead of a JSON object. This PR modifies odo to correctly handle this change, preventing errors in commands like odo debug and odo logs when running on Podman.

Which issue(s) this PR fixes:

Fixes #7252

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. area/odo-on-podman Issues or PRs related to running odo against Podman needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. labels Oct 9, 2024
Copy link

openshift-ci bot commented Oct 9, 2024

Hi @too-common-name. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested review from kadel and rm3l October 9, 2024 16:02
Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 74f5ae4
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/67095764dd2213000819a953

@rm3l
Copy link
Member

rm3l commented Oct 9, 2024

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. labels Oct 9, 2024
Copy link

Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @too-common-name !!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 12, 2024
@rm3l rm3l merged commit b5bad42 into redhat-developer:main Oct 12, 2024
18 of 19 checks passed
@too-common-name
Copy link
Contributor Author

Thank you for merging this! This was my first contribution as a RedHatter, and I'm really excited to have been able to help improve odo. I hope this is just the first of many contributions to come. Looking forward to learning more and contributing further to the community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/odo-on-podman Issues or PRs related to running odo against Podman kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error running commands when using platform=podman
2 participants