-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: manage podman inspect result as a list also #7269
fix: manage podman inspect result as a list also #7269
Conversation
Hi @too-common-name. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
/ok-to-test |
Co-authored-by: Armel Soro <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @too-common-name !!
Thank you for merging this! This was my first contribution as a RedHatter, and I'm really excited to have been able to help improve odo. I hope this is just the first of many contributions to come. Looking forward to learning more and contributing further to the community! |
What type of PR is this:
/kind bug
/area odo-on-podman
What does this PR do / why we need it:
This PR addresses an issue when using the
odo
commands with Podman, specifically related to thepodman pod inspect
command. Due to a recent change in Podman (see podman PR #21514), the output now returns a JSON array instead of a JSON object. This PR modifiesodo
to correctly handle this change, preventing errors in commands likeodo debug
andodo logs
when running on Podman.Which issue(s) this PR fixes:
Fixes #7252
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: