Update to Prettier 3 #909
Merged
Update to Prettier 3 #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| describe('Test that formatter works with custom tags', function () { | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| function parseSetup(content: string, options: any = {}): TextEdit[] { | ||
| function parseSetup(content: string, options: any = {}): Promise<TextEdit[]> { |
Check warning
Code scanning / ESLint
Disallow the `any` type Warning test
|
@msivasubramaniaan This would be a nice enhancement to support Prettier v3, otherwise we are forced deliver 2 versions of Prettier within our app. |
remcohaszing
force-pushed
the
prettier-3
branch
2 times, most recently
from
e0de8a6 to
6dd6e31
Compare
remcohaszing
force-pushed
the
prettier-3
branch
2 times, most recently
from
c8ac1c6 to
678e80a
Compare
msivasubramaniaan
requested changes
Dec 18, 2024
Contributor
msivasubramaniaan
left a comment
msivasubramaniaan
left a comment
There was a problem hiding this comment.
Seeing lots of lint changes. Kindly rebase and raise PR only with affected files
remcohaszing
force-pushed
the
prettier-3
branch
from
8e3a1c4 to
9b48180
Compare
Contributor
Author
|
Done, but now CI fails. It’s hard to tell intent, because both ESLint are Prettier are not configured correctly for this repo. |
- Prettier 3 is async, so related functions were made async. - Code was reformatted using Prettier. - Prettier now ships their own types, so `@types/prettier` was removed. - Prettier was moved to `dependencies`. `optionalDependencies` is for dependencies that have a `install` script that may fail. This isn’t the case for Prettier. - `eslint-config-prettier` was updated as well. - `eslint-plugin-prettier` was updated as well.
remcohaszing
force-pushed
the
prettier-3
branch
from
9b48180 to
0db58e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This updates Prettier to version 3.
@types/prettierwas removed.dependencies.optionalDependenciesis for dependencies that have ainstallscript that may fail. This isn’t the case for Prettier.eslint-plugin-prettierwas updated as well.Alternatively the formatting functionality could be removed. IMO people should just use Prettier themselves for formatting YAML instead of relying on this
yaml-language-server.What issues does this PR fix or reference?
N/A
Is it tested? How?
npm test