Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge static check and report static check tasks #785

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Merge static check and report static check tasks #785

merged 1 commit into from
Feb 17, 2025

Conversation

Allda
Copy link
Contributor

@Allda Allda commented Feb 13, 2025

There is no reason to keep these 2 Tekton task separate. This commit merged it into one to save OCP resources and speedup the execution time.

Merge Request Checklists

  • Development is done in feature branches
  • Code changes are submitted as pull request into a primary branch [Provide reason for non-primary branch submissions]
  • Code changes are covered with unit and integration tests.
  • Code passes all automated code tests:
    • Linting
    • Code formatter - Black
    • Security scanners
    • Unit tests
    • Integration tests
  • Code is reviewed by at least 1 team member
  • Pull request is tagged with "risk/good-to-go" label for minor changes

@Allda
Merge static check and report static check tasks
fc52404 
There is no reason to keep these 2 Tekton task separate. This commit
merged it into one to save OCP resources and speedup the execution time.

Signed-off-by: Ales Raszka <[email protected]>
@Allda Allda requested review from jedinym and tomasbakk February 13, 2025 15:46
@Allda Allda merged commit 0b21087 into main Feb 17, 2025
4 checks passed
@Allda Allda deleted the static-check-merge branch February 17, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedinym jedinym jedinym approved these changes

@tomasbakk tomasbakk tomasbakk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Allda @jedinym @tomasbakk