Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create channel if not exists in basic template #793

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Create channel if not exists in basic template #793

merged 1 commit into from
Feb 26, 2025

Conversation

Allda
Copy link
Contributor

@Allda Allda commented Feb 26, 2025 •
edited
Loading

The auto-release FBC script skipped channels in case they didn't exist. The new code change checks if a requested channel given by the release config exists and if not, create it and add a bundle to it.

JIRA: ISV-5670

Closes #791

Merge Request Checklists

  • Development is done in feature branches
  • Code changes are submitted as pull request into a primary branch [Provide reason for non-primary branch submissions]
  • Code changes are covered with unit and integration tests.
  • Code passes all automated code tests:
    • Linting
    • Code formatter - Black
    • Security scanners
    • Unit tests
    • Integration tests
  • Code is reviewed by at least 1 team member
  • Pull request is tagged with "risk/good-to-go" label for minor changes

@Allda
Create channel if not exists in basic template
2947be6 
The auto-release FBC script skipped channels in case they didn't exist.
The new code change checks if a requested channel given by the release
config exists and if not, create it and add a bundle to it.

JIRA: ISV-5670

Closes 791

Signed-off-by: Ales Raszka <[email protected]>
@Allda Allda requested a review from mantomas February 26, 2025 12:30
mantomas
mantomas approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@mantomas mantomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Allda Allda merged commit d7676e4 into main Feb 26, 2025
3 checks passed
@Allda Allda deleted the ISV-5670 branch February 26, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantomas mantomas mantomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add-bundle-to-fbc does not add channel
2 participants
@Allda @mantomas