Fix Kafka Connect consumer override config - #15
Open
jruaux wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note
Low Risk
Documentation and sample-only Docker/Connect configuration; no production service or auth changes.
Overview
Adds a Kafka Connect sample under
samples/kafka-connectthat runs Korvet with Redis, a standalone Connect worker, a built-in file sink, and a looping JSON producer on topicdw-scte, with Makefile helpers and docs linked from the root and samples READMEs. Generated sink output is gitignored viasamples/kafka-connect/output/.Connect behavior is tuned so connector consumer settings actually apply: the worker sets
connector.client.config.override.policy=All, and the file sink usesconsumer.override.auto.offset.reset=latest(documented in the sample README) so the sink starts at latest offsets instead of ignoring a non-prefixed override.Reviewed by Cursor Bugbot for commit 00487a3. Bugbot is set up for automated code reviews on this repo. Configure here.