Tombstone messages in kafka should trigger the conditional delete not throw an error - #48
Open
andrecowie wants to merge 4 commits into
Open
Tombstone messages in kafka should trigger the conditional delete not throw an error#48andrecowie wants to merge 4 commits into
andrecowie wants to merge 4 commits into
Conversation
Author
|
@jruaux Hey I see you are the maintainer, do you think you could comment on this PR keen to get this in. It is I think an important functionality to enable kafka tombstones to remove the value set in redis. If you want me to add a configuration param to be able to enable this let me know? |
kpreston1
approved these changes
Nov 24, 2025
Author
|
Can we please merge this in @kpreston1 ? |
Author
|
@jruaux any feedback? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets say I create a sink:
I want a tombstone record in kafka to trigger a delete in redis.
Currently It just throws an error and doesn't delete this change resolves this by allowing the conditional del function to run.
I also updated the java version to 21 from 17.