fix(reader): implement retry logic for opening Redis reader - #65
Open
sauravkumarrr wants to merge 3 commits into
Open
fix(reader): implement retry logic for opening Redis reader#65sauravkumarrr wants to merge 3 commits into
sauravkumarrr wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 40f436d. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
reader.open()inRedisKeysSourceTask.start()to handle transientConcurrentModificationExceptionfromspring-batch-redis'sJobUtils.hsqldbDataSource()— the staticHashMap.computeIfAbsentis not thread-safe on Java 9+RetriableExceptionwithConnectExceptionafter exhausting retries, sinceRetriableExceptionhas no effect during task startup (Connect treats it as unrecoverable and kills the task)reader.close()andclient.shutdown()in try-catch instop()to prevent zombie connectors when cleanup fails on partially-initialized stateContext
In production, a single keys source connector (
lcc-99wr75) entered a 2+ week death spiral:ConcurrentModificationExceptioninHashMap.computeIfAbsentduringreader.open()→ task killed as "unrecoverable"The root cause is in
spring-batch-redis-infrastructure(tested 4.6.2 and 4.8.0) —JobUtils.dataSourcesis a plainHashMapinstead ofConcurrentHashMap. This fix works around the upstream bug.Note
Medium Risk
Touches Kafka Connect task startup/shutdown paths and introduces blocking retry sleeps, which can affect connector availability and thread usage if misbehaving. Scope is limited to the Redis keys source task and adds bounded retries with clearer failure behavior.
Overview
Improves resilience of the Redis keys source task during startup and shutdown.
RedisKeysSourceTask.start()now opens theRedisItemReadervia a newopenReaderWithRetry()helper that retriesreader.open()up to 3 times with a 1s delay, logs failures, closes partially-open readers between attempts, and ultimately fails withConnectException(replacing the priorRetriableExceptionstartup behavior).Hardens cleanup to prevent stuck/zombie tasks.
stop()now wrapsreader.close(),client.shutdown(), andclient.getResources().shutdown()in try/catch with warnings so shutdown proceeds even if some resources fail to close.Reviewed by Cursor Bugbot for commit b2265f5. Bugbot is set up for automated code reviews on this repo. Configure here.