Skip to content

Conversation

@fumiyanokesinn
Copy link

@fumiyanokesinn fumiyanokesinn commented Dec 25, 2025

Change isSimpleByte range from 0x21-0x7e to 0x20-0x7e to include space character.

Previously, queries like *=>[KNN 10 @v $v] were hex-encoded, making them unreadable in OpenTelemetry traces.

fixes #3204

Before extra/rediscmd/rediscmd_test.go

=== RUN   TestGinkgo
Running Suite: redisext - /Users/user/Workspace/go-redis/extra/rediscmd
=======================================================================
Random Seed: 1766668840

Will run 9 of 9 specs
••••
------------------------------
• [FAILED] [0.000 seconds]
AppendArg ... [It] 
/Users/user/Workspace/go-redis/extra/rediscmd/rediscmd_test.go:26

  [FAILED] Expected
      <string>: 666f6f20626172
  to equal
      <string>: foo bar
  In [It] at: /Users/user/Workspace/go-redis/extra/rediscmd/rediscmd_test.go:19 @ 12/25/25 22:20:40.917
------------------------------
••••

Summarizing 1 Failure:
  [FAIL] AppendArg ... [It] 
  /Users/user/Workspace/go-redis/extra/rediscmd/rediscmd_test.go:19

Ran 9 of 9 Specs in 0.001 seconds
FAIL! -- 8 Passed | 1 Failed | 0 Pending | 0 Skipped
--- FAIL: TestGinkgo (0.00s)
FAIL
FAIL    github.com/redis/go-redis/extra/rediscmd/v9     0.432s

After extra/rediscmd/rediscmd_test.go

=== RUN   TestGinkgo
Running Suite: redisext - /Users/user/Workspace/go-redis/extra/rediscmd
=======================================================================
Random Seed: 1766668833

Will run 9 of 9 specs
•••••••••

Ran 9 of 9 Specs in 0.001 seconds
SUCCESS! -- 9 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestGinkgo (0.00s)
PASS
ok      github.com/redis/go-redis/extra/rediscmd/v9     (cached)

@jit-ci
Copy link

jit-ci bot commented Dec 25, 2025

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make query in FT.SEARCH human readable

1 participant