Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change FT.PROFILE to return generic object #4067

Merged
merged 7 commits into from
Jan 30, 2025
Merged

Change FT.PROFILE to return generic object #4067

merged 7 commits into from
Jan 30, 2025

Conversation

sazzad16
Copy link
Contributor

@sazzad16 sazzad16 commented Jan 20, 2025 •
edited
Loading

Closes #3867

@sazzad16 sazzad16 added this to the 6.0.0 milestone Jan 20, 2025
@sazzad16 sazzad16 added breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. maintenance labels Jan 20, 2025
@sazzad16 sazzad16 requested review from uglide and ggivo January 21, 2025 10:29
uglide
uglide previously approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@uglide uglide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ggivo
ggivo previously approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@ggivo ggivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

LGTM

@sazzad16 sazzad16 dismissed stale reviews from ggivo and uglide via b2c7a02 January 30, 2025 16:51
@sazzad16 sazzad16 merged commit cd9346a into redis:master Jan 30, 2025
7 of 8 checks passed
@sazzad16 sazzad16 deleted the ft-profile-info branch January 30, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uglide uglide uglide left review comments

@ggivo ggivo ggivo left review comments

Assignees
No one assigned
Labels
breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. maintenance
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sazzad16 @uglide @ggivo