Skip to content

Commit

Permalink
fix review issues
Browse files Browse the repository at this point in the history
  • Loading branch information
kiryazovi-redis committed Feb 14, 2025
1 parent 468fc62 commit 79ed4b0
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 17 deletions.
6 changes: 0 additions & 6 deletions .github/workflows/benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,6 @@ jobs:
env:
JVM_OPTS: -Xmx3200m
TERM: dumb
- name: Clean environment
run: |
make cleanup
env:
JVM_OPTS: -Xmx3200m
TERM: dumb
- name: Tear down Docker Compose environment
run: |
docker compose $COMPOSE_ENV_FILES -f src/test/resources/docker-env/docker-compose.yml down
Expand Down
9 changes: 0 additions & 9 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ jobs:
fail-fast: false
matrix:
redis_version:
- "unstable"
- "8.0"
- "7.4"
- "7.2"
Expand All @@ -37,7 +36,6 @@ jobs:
run: |
# Map requested version to github or tag
case "${{ matrix.redis_version }}" in
"unstable") redis_branch="unstable" stack_version="8.0-M04-pre" redis_test_version="8.0-M04-pre";;
"8.0") redis_branch="8.0" stack_version="8.0-M04-pre" redis_test_version="8.0-M04-pre";;
"7.4") redis_branch="7.4" stack_version="rs-7.4.0-v2" redis_test_version="7.4.2";;
"7.2") redis_branch="7.2" stack_version="rs-7.2.0-v14" redis_test_version="7.2.7";;
Expand Down Expand Up @@ -81,13 +79,6 @@ jobs:
REDIS_STACK_VERSION: ${{ steps.map-tags.outputs.redis_stack_version }}
JVM_OPTS: -Xmx3200m
TERM: dumb
- name: Clean environment
run: |
sudo rm -rf $REDIS_ENV_WORK_DIR
make clean
env:
JVM_OPTS: -Xmx3200m
TERM: dumb
- name: Tear down Docker Compose environment
run: |
docker compose $COMPOSE_ENV_FILES -f src/test/resources/docker-env/docker-compose.yml down
Expand Down
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -155,15 +155,14 @@ Building
-----------

Lettuce is built with Apache Maven. The tests require multiple running Redis instances for different test cases which
are configured using a ```Makefile```. Tests run by default against Redis `unstable`.
are configured using a ```Makefile```. Tests run by default against Redis `latest`.

To build:

```
$ git clone https://github.com/redis/lettuce.git
$ cd lettuce/
$ make docker-start
$ make docker-test
```

* Run the build: ```make docker-test```
Expand Down

0 comments on commit 79ed4b0

Please sign in to comment.