fix memory leak issue on thread local in sharedLock - PR for main branch#3640
Open
kandogu wants to merge 1 commit intoredis:mainfrom
Open
fix memory leak issue on thread local in sharedLock - PR for main branch#3640kandogu wants to merge 1 commit intoredis:mainfrom
kandogu wants to merge 1 commit intoredis:mainfrom
Conversation
Author
|
@a-TODO-rov Hello, |
Contributor
|
I think this might work.
@tishun what are your thoughts on this ? |
Collaborator
|
Awesome job @kandogu; and thanks for testing this @a-TODO-rov. IMHO we can merge this. |
c495257 to
2f3ce1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: SharedLock ThreadLocal memory leak in connection pooling scenarios #3489
Summary
This PR fixes the
ThreadLocalmemory leak inSharedLockthat causes high CPU usage fromThreadLocalMap.expungeStaleEntries()when using connection pooling (shareNativeConnection=false).Fixes #3489
Problem
The original implementation created a per-instance
ThreadLocal<Integer>for eachSharedLock:With connection pooling:
DefaultEndpoint→SharedLockSharedLockcreates an entry in itsThreadLocalMapSharedLockinstances are garbage collectedThreadLocalMapexpungeStaleEntries()becomes expensive, causing CPU spikesSolution
Replace per-instance
ThreadLocalwith a staticThreadLocal<WeakHashMap<SharedLock, Integer>>:Key benefits:
ThreadLocalentry per thread (not perSharedLock)WeakHashMapkeys allowSharedLockto be garbage collected, automatically removing entriesMemory Comparison
ThreadLocalMapentriesChanges
SharedLock.java: Refactored to use staticThreadLocal<WeakHashMap<SharedLock, Integer>>SharedLockUnitTests.java: Added tests for new behaviorChecklist
mvn formatter:formattarget. Don't submit any formatting related changes.