Move topology filtering logic #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reverts changes on `__runner__/args.py` - reverts changes on `__self_contained_coordinator__/runners.py`
fcostaoliveira
approved these changes
May 9, 2025
paulorsousa
added a commit
that referenced
this pull request
May 9, 2025
* Add topology filter to runners.py * Move new topology filtering logic to `self_contained_coordinator.py` (#289) - reverts changes on `__runner__/args.py` - reverts changes on `__self_contained_coordinator__/runners.py` --------- Co-authored-by: Paulo Sousa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By analysing the code, git history and unit tests I think that
process_self_contained_coordinator_streamis now onredis_benchmarks_specification/__self_contained_coordinator__/self_contained_coordinator.pyfile.This PR moves the filtering logic from
runners.pytoself_contained_coordinator.py.