-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed a potential bug #337
Conversation
Signed-off-by: wiseaidev <[email protected]>
Signed-off-by: wiseaidev <[email protected]>
Signed-off-by: wiseaidev <[email protected]>
Signed-off-by: wiseaidev <[email protected]>
Signed-off-by: wiseaidev <[email protected]>
Signed-off-by: wiseaidev <[email protected]>
Signed-off-by: wiseaidev <[email protected]>
Signed-off-by: wiseaidev <[email protected]>
) | ||
|
||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
@wiseaidev Great PR, thanks! Can you solve the linter issue so that all the tests will run and we can merge it? |
Signed-off-by: wiseaidev <[email protected]>
Hey @dvora-h, done! Do i need to push the |
I see what's wrong, working on it! ping @dvora-h |
Signed-off-by: wiseaidev <[email protected]>
Signed-off-by: wiseaidev <[email protected]>
@wiseaidev Thanks for the quick fixes! |
Related to #322
The reason for removing
six
, assuming you are using python 3.7+, is that it has the same memory footprint as the built-in range method:Therefore, no benefits from using it instead of
range
.