Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancing primary key check to be compatible with sqlmodel #672

Merged
merged 3 commits into from
Jan 17, 2025
Merged

enhancing primary key check to be compatible with sqlmodel #672

merged 3 commits into from
Jan 17, 2025

Conversation

slorello89
Copy link
Member

No description provided.

@slorello89 slorello89 linked an issue Nov 19, 2024 that may be closed by this pull request
Using Field from a different class causes the validator to wrongly assume there are multiple primary keys #671
Closed
bsbodden
bsbodden approved these changes Jan 13, 2025
View reviewed changes
Copy link

@bsbodden bsbodden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@slorello89 slorello89 merged commit 82406f0 into main Jan 17, 2025
10 checks passed
@slorello89 slorello89 deleted the primarykeycheck branch January 17, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsbodden bsbodden bsbodden approved these changes

@guyroyse guyroyse Awaiting requested review from guyroyse

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using Field from a different class causes the validator to wrongly assume there are multiple primary keys
2 participants
@slorello89 @bsbodden