-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Client side caching refactoring #3350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 88 commits
Commits
Show all changes
89 commits
Select commit
Hold shift + click to select a range
629d3db
Restructure client side caching code
gerzse 48607e9
Temporary refactor
vladvildanov 2c0c812
Finished CacheProxyConnection implementation, added comments
vladvildanov a734303
Added test cases and scheduler dependency
vladvildanov 339735c
Added support for RedisCluster and multi-threaded test cases
vladvildanov 88f7e54
Added support for BlockingConnectionPool
vladvildanov 936be84
Fixed docker-compose command
vladvildanov eb95bd3
Revert port changes
vladvildanov 2c50adc
Initial take on Sentinel support
vladvildanov 6f582a0
Remove keys option after usage
vladvildanov 59fe379
Added condition to remove keys entry on async
vladvildanov eaeef12
Added same keys entry removal in pipeline
vladvildanov 33f656e
Added caching support for Sentinel
vladvildanov e77cb60
Added locking when accesing cache object
vladvildanov 2a14e13
Rmoved keys option from options
vladvildanov 64fb176
Removed redundant entities
vladvildanov 47e6c7a
Added cache support for SSLConnection
vladvildanov eec44bd
Moved ssl argument handling to cover cluster case
vladvildanov 5422955
Revert local test changes
vladvildanov 41190d7
Fixed bug with missing async operator
vladvildanov 6146d13
Revert accidental changes
vladvildanov d184d6b
Added API to return cache object
vladvildanov fe124e1
Added eviction policy configuration
vladvildanov 21778be
Added mark to skip test on cluster
vladvildanov 0eb018b
Merge branch 'master' into client-side-caching-improvements
vladvildanov 19c8f35
Removed test case that makes no sense
vladvildanov 3d7f84b
Merge branch 'client-side-caching-improvements' of github.com:redis/r…
vladvildanov 7edb46b
Skip tests in RESP2
vladvildanov e6ebab6
Added scheduler to dev_requirements
vladvildanov 852c36f
Codestyle changes
vladvildanov 726803a
Fixed characters per line restriction
vladvildanov bed4d73
Fixed line length
vladvildanov a78690a
Removed blank lines in imports
vladvildanov c685248
Fixed imports codestyle
vladvildanov 65bd5af
Added CacheInterface abstraction
vladvildanov 9e9b68c
Removed redundant references
vladvildanov ba94215
Moved hardcoded values to constants, restricted dependency versions
vladvildanov 2572167
Changed defaults to correct values
vladvildanov 74499a9
Added custom background scheduler, added unit testing
vladvildanov da32b9e
Codestyle changes
vladvildanov 36de29b
Updated RESP2 restriction
vladvildanov b023619
Cahnged typing to more generic
vladvildanov 9fe36f8
Restrict pytest-asyncio version to 0.23
vladvildanov 8a2a01e
Added upper version limit
vladvildanov 7b50300
Removed usntable multithreaded tests
vladvildanov 73cb068
Removed more flacky multithreaded tests
vladvildanov ad7e977
Fixed issue with Sentinel killing healthcheck thread before execution
vladvildanov c106873
Removed cachetools dependency, added custom cache implementation
vladvildanov d78c5d3
Updated test cases
vladvildanov 9cac761
Updated typings
vladvildanov 43af6ee
Updated types
vladvildanov fa1a431
Revert changes
vladvildanov 0ffc298
Removed use_cache, make health_check configurable, removed retry logi…
vladvildanov 4459dd6
Revert test skip
vladvildanov 6e522e1
Merge branch 'master' into client-side-caching-improvements
vladvildanov 9fb5aa2
Added documentation and codestyle fixes
vladvildanov 13a9b2d
Merge branch 'client-side-caching-improvements' of github.com:redis/r…
vladvildanov 01e405e
Updated excluded wordlist
vladvildanov 6b61f1a
Merge branch 'master' into client-side-caching-improvements
vladvildanov 9ddc9c6
Merge branch 'master' into client-side-caching-improvements
vladvildanov b5a8133
Added health_check thread cancelling in BlockingPool
vladvildanov 471c7cb
Merge branch 'client-side-caching-improvements' of github.com:redis/r…
vladvildanov face34a
Merge branch 'master' into client-side-caching-improvements
vladvildanov 4035ce6
Revert argument rename, extended documentation
vladvildanov b434efd
Merge branch 'client-side-caching-improvements' of github.com:redis/r…
vladvildanov 6c47c64
Updated NodesManager to create shared cache between all nodes
vladvildanov c47d4aa
Codestyle fixes
vladvildanov fd361a7
Updated docs
vladvildanov 97ebebf
Added version restrictions
vladvildanov 6387a86
Added missing property getter
vladvildanov 097d92e
Updated Redis server version
vladvildanov c2a4edf
Skip on long exception message
vladvildanov c110207
Removed keys entry as it's csc specific
vladvildanov e3980b6
Merge branch 'master' into client-side-caching-improvements
vladvildanov ffff100
Updated exception message for CSC
vladvildanov f684739
Merge branch 'client-side-caching-improvements' of github.com:redis/r…
vladvildanov 9852b78
Updated condition by adding server name check
vladvildanov 97abacd
Added test coverage for decoded responses
vladvildanov 20f3851
Codestyle changes
vladvildanov 2d8cf27
Removed background healthcheck, use connection reference approach ins…
vladvildanov 1f6876a
Removed unused imports
vladvildanov 30717aa
Fixed broken tests
vladvildanov 98bf72d
Codestyle changes
vladvildanov cdf8504
Fixed additional broken tests
vladvildanov 7340aad
Codestyle changes
vladvildanov c36219f
Increased timer to avoid flackiness
vladvildanov 6d63a59
Restrict tests cause of PyPy
vladvildanov 18a4d3d
Codestyle changes
vladvildanov 94ddab1
Updated docs, convert getters function to properties, added dataclasses
vladvildanov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
APM | ||
ARGV | ||
BFCommands | ||
CacheImpl | ||
CFCommands | ||
CMSCommands | ||
ClusterNode | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
black==24.3.0 | ||
cachetools | ||
click==8.0.4 | ||
flake8-isort | ||
flake8 | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.