Skip to content

DOC-5107 added hash examples for index/query intro page #3609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andy-stark-redis
Copy link
Contributor

@andy-stark-redis andy-stark-redis commented Apr 17, 2025

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?

Description of change

DOC-5107

Extra examples that will be added to this page to demonstrate hash indexing.

@andy-stark-redis andy-stark-redis self-assigned this Apr 17, 2025
@andy-stark-redis andy-stark-redis marked this pull request as ready for review April 22, 2025 08:58
@@ -10,7 +10,7 @@
import redis.commands.search.aggregation as aggregations
import redis.commands.search.reducers as reducers
from redis.commands.search.field import TextField, NumericField, TagField
from redis.commands.search.indexDefinition import IndexDefinition, IndexType
from redis.commands.search.index_definition import IndexDefinition, IndexType
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andy-stark-redis this index_definition path was changed on several other places as part of PR#3490. Since now there is a beta release containing this path, can you please change in the other files as well(https://github.com/redis/redis-py/pull/3490/files)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants