Hold references to ClusterNode disconnect task#3826
Open
rhoboro wants to merge 1 commit intoredis:masterfrom
Open
Hold references to ClusterNode disconnect task#3826rhoboro wants to merge 1 commit intoredis:masterfrom
rhoboro wants to merge 1 commit intoredis:masterfrom
Conversation
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
Collaborator
|
Hi @rhoboro, thank you for your contribution! We will review your change soon. |
rhoboro
commented
Nov 1, 2025
| task = asyncio.create_task(old.pop(name).disconnect()) # noqa | ||
| task = asyncio.create_task(old.pop(name).disconnect()) | ||
| self._background_tasks.add(task) | ||
| task.add_done_callback(self._background_tasks.discard) |
Author
There was a problem hiding this comment.
Fixed an issue where if multiple tasks were created, all but the last one would no longer be strongly referenced. Tasks that are not strongly referenced can be deleted by the GC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for this awesome library! I've been a long-time user of this project ✨
Pull Request check-list
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
I found a potential bug and have fixed it.
This fix aligns with the recommendations in the official documentation linked below, as I have personally encountered unintended task loss due to this issue in the past.
https://docs.python.org/3.13/library/asyncio-task.html#asyncio.create_task