Skip to content

remove remaining imports of typing_extensions#3873

Open
dotlambda wants to merge 2 commits intoredis:masterfrom
dotlambda:typing-extensions
Open

remove remaining imports of typing_extensions#3873
dotlambda wants to merge 2 commits intoredis:masterfrom
dotlambda:typing-extensions

Conversation

@dotlambda
Copy link

@dotlambda dotlambda commented Dec 9, 2025

Description of change

It's not a dependency anymore:

dependencies = ['async-timeout>=4.0.3; python_full_version<"3.11.3"']

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

@petyaslavova
Copy link
Collaborator

Hi @dotlambda, thank you for your contribution! We will review your change soon.

from typing_extensions import Optional

try:
from typing import Optional # Py 3.11+
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can directly import it from typing and completely remove the typing_extensions import. The typing.Optional is available in our min supported version, which is 3.10

@petyaslavova petyaslavova added the maintenance Maintenance (CI, Releases, etc) label Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Maintenance (CI, Releases, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants