fix(asyncio): prevent deadlock when Lock.release() is cancelled #3900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3847 where cancelling
release()during execution could leave the async lock in an inconsistent deadlock state.Root Cause
The
release()method clearedself.local.tokensynchronously before returning the awaitabledo_release(). If the caller cancelled the await, the token was already gone but the Redis key still existed, causing:lock.owned()returns False (no token)lock.locked()returns True (Redis key exists)Solution
Convert
release()to async and clear token only AFTER successful release.Edge Cases Handled
Testing
test_release_cancellation_preserves_lock_stateregression testBackward Compatibility
await lock.release()- no changes needed