Add Sentinel +switch-master linstener option to monitor failovers.#3915
Open
ManelCoutinhoSensei wants to merge 1 commit intoredis:masterfrom
Open
Add Sentinel +switch-master linstener option to monitor failovers.#3915ManelCoutinhoSensei wants to merge 1 commit intoredis:masterfrom
ManelCoutinhoSensei wants to merge 1 commit intoredis:masterfrom
Conversation
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
102f286 to
f22bb84
Compare
Collaborator
|
Hi @ManelCoutinhoSensei, thank you for your contribution! We will have a look at it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Fix for #3867 inspired by the redis-go library.
This solution adds a thread that cycles through valid sentinel clients to listen for
+switch-masterevents whenever a failover happens and the user decided to monitor it.It also provides a first step to implement a solution for #3543.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.