-
Notifications
You must be signed in to change notification settings - Fork 3
Add support for modularity #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR probably fixes #4. |
Maybe, this PR is just an exercise, with no helpful impact. - The classpath variable needs to be populated to get the java modularity plugin to work. - I tried to port the idea of the fix to it at java9-modularity/gradle-modules-plugin#281. I leave the PR open, maybe there is someone using modules without the |
Can you update the PR to add a note in the README about it? |
I tried to craft some text 😅 |
After this is merged, a release should be made - and one can answer https://stackoverflow.com/q/10519558/873282 properly (a) point to the |
@rocketraman I think, with |
Sorry for the delay. Thank you! Unfortunately I have been unable to get an update published to the Gradle Plugin Repo. |
Thank you for merging! Should I ping you in some weeks regarding publishing? 😅 |
I just resubmitted it again. Hopefully it works this time -- they cancelled the request because the GAV changed due to the updated Gradle plugin publishing plugin. Feel free to ping / follow-up in a couple weeks. |
I think, looks kinda good: (from https://plugins.gradle.org/plugin/com.redock.classpathtofile) Could you maybe also set the tag in this repository maybe? --> https://github.com/redocksoft/classpath-to-file-gradle-plugin/tags is currently empty. |
Nice, thanks! Here you go: https://github.com/redocksoft/classpath-to-file-gradle-plugin/releases/tag/v0.1.0 |
In a modularized project, one need
--module-path
instead of-cp
.This PR adds support for it.