Skip to content

Add support for modularity #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2025

Conversation

koppor
Copy link
Contributor

@koppor koppor commented Jul 3, 2024

In a modularized project, one need --module-path instead of -cp.

This PR adds support for it.

@koppor
Copy link
Contributor Author

koppor commented Jul 3, 2024

This PR probably fixes #4.

@koppor
Copy link
Contributor Author

koppor commented Jul 4, 2024

Maybe, this PR is just an exercise, with no helpful impact. - The classpath variable needs to be populated to get the java modularity plugin to work. - I tried to port the idea of the fix to it at java9-modularity/gradle-modules-plugin#281.

I leave the PR open, maybe there is someone using modules without the java9-modularity plugin.

@rocketraman
Copy link
Collaborator

Can you update the PR to add a note in the README about it?

@koppor
Copy link
Contributor Author

koppor commented Jul 4, 2024

I tried to craft some text 😅

@koppor
Copy link
Contributor Author

koppor commented Jul 4, 2024

After this is merged, a release should be made - and one can answer https://stackoverflow.com/q/10519558/873282 properly (a) point to the @ cheat and b) advertise this plugin)

@koppor
Copy link
Contributor Author

koppor commented Mar 11, 2025

Can you update the PR to add a note in the README about it?

@rocketraman I think, with 987afd2 (#7) this wish is implemented.

@rocketraman rocketraman merged commit fbb56e4 into redocksoft:master Mar 29, 2025
1 check passed
@rocketraman
Copy link
Collaborator

Sorry for the delay. Thank you! Unfortunately I have been unable to get an update published to the Gradle Plugin Repo.

@koppor
Copy link
Contributor Author

koppor commented Mar 29, 2025

Sorry for the delay. Thank you! Unfortunately I have been unable to get an update published to the Gradle Plugin Repo.

Thank you for merging!

Should I ping you in some weeks regarding publishing? 😅

@rocketraman
Copy link
Collaborator

Should I ping you in some weeks regarding publishing? 😅

I just resubmitted it again. Hopefully it works this time -- they cancelled the request because the GAV changed due to the updated Gradle plugin publishing plugin.

Feel free to ping / follow-up in a couple weeks.

@koppor koppor deleted the add-modularity-support branch March 31, 2025 10:16
@koppor
Copy link
Contributor Author

koppor commented Apr 19, 2025

I think, looks kinda good:

image

(from https://plugins.gradle.org/plugin/com.redock.classpathtofile)

Could you maybe also set the tag in this repository maybe? --> https://github.com/redocksoft/classpath-to-file-gradle-plugin/tags is currently empty.

@rocketraman
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants