🐛 Support CSS custom properties in createCursor
#95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is an issue when passing a CSS custom property to the
createCursor
method:While the flag and the caret colour are set correctly, modifying the alpha value for the selection block fails. This results in
rgb(0, 0, 0)
as a CSS variable is not a valid input fortinycolor
.quill-cursors/src/quill-cursors/cursor.ts
Line 174 in 5524fbb
This change addresses the issue by applying the fade effect via the
opacity
property instead of manipulating thealpha
channel.Note
This will slightly change functionality, as before the existing opacity would be overwritten (for example, passing
rgba(0, 0, 0, 0.5)
would result in the selection block beingrgba(0, 0, 0, 0.3)
). Now the fade will apply to the existing colour (so the previous example will result inrgba(0, 0, 0, 0.15)
instead).This behaviour is more intuitive, especially when working with colours that have alpha values less than
0.3
. Previously, these would result in the fade making the colour stronger instead of lighter.