Add sending slack notification on deploy #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdowolski-reef
commented
Jun 11, 2022
| @@ -27,6 +27,11 @@ docker-compose run --rm app sh -c "python manage.py wait_for_database --timeout | |||
| # start everything | |||
| docker-compose up -d | |||
|
|
|||
| {% if cookiecutter.use_slack_notification %} | |||
| # Send slack notification about deploy | |||
| docker-compose run --rm app sh -c "python bin/notify.py" | |||
There was a problem hiding this comment.
Not sure how working with that template looks like in real but deploy-to-aws (which is called by github action) doesn't call deploy (or I don't see something). If so, the problem where to call it stands.
There was a problem hiding this comment.
What solution do you suggest?
There was a problem hiding this comment.
kdowolski-reef
commented
Jun 11, 2022
ppolewicz
reviewed
Jun 11, 2022
| @@ -27,6 +27,11 @@ docker-compose run --rm app sh -c "python manage.py wait_for_database --timeout | |||
| # start everything | |||
| docker-compose up -d | |||
|
|
|||
| {% if cookiecutter.use_slack_notification %} | |||
| # Send slack notification about deploy | |||
| docker-compose run --rm app sh -c "python bin/notify.py" | |||
There was a problem hiding this comment.
What solution do you suggest?
kdowolski-reef
force-pushed
the
master
branch
7 times, most recently
from
f44ef61 to
3ff6493
Compare
kdowolski-reef
commented
Jun 19, 2022
| @@ -29,7 +29,8 @@ docker-compose up -d | |||
|
|
|||
| {% if cookiecutter.use_slack_notification %} | |||
| # Send slack notification about deploy | |||
| docker-compose run --rm app sh -c "python bin/notify.py" | |||
| output=`git log --format=format:%H,%s` | |||
| docker-compose run --rm app sh -c "python /root/src/bin/notify.py --parse -m \"$output\"" | |||
There was a problem hiding this comment.
Unfortunately it allows for code injection with backticks, searching how to escape it properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.