Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set dynamic coaching session titles #35

Merged
merged 4 commits into from
Oct 5, 2024
Merged

Conversation

jhodapp
Copy link
Member

@jhodapp jhodapp commented Oct 2, 2024

Description

This PR constructs a title for a coaching session in 4 different styles (first names only, first and last names, first names + date, first names + date and time).

GitHub Issue: None

Changes

  • Add a new CoachingSessionTitle component to render a dynamic coaching session title
  • Add a new SessionTitle object type
  • Store CoachingSession and CoachingRelationship instances in AppStateStore instead of only coachingSessionId and relationshipId.

Screenshots / Videos Showing UI Changes (if applicable)

Jim __ Caleb _ Oct 3_ 2024

Testing Strategy

Navigate to a coaching session and observe that a title is shown (should be in the style of first names + date by default)

Concerns

None

@jhodapp jhodapp added enhancement Improves existing functionality or feature feature work Specifically implementing a new feature labels Oct 2, 2024
@jhodapp jhodapp self-assigned this Oct 2, 2024
@jhodapp jhodapp requested review from qafui and calebbourg October 2, 2024 21:20
…me type at render or calculation time to prevent TypeError exceptions and down-casting issues to just a Date.
@jhodapp jhodapp marked this pull request as ready for review October 4, 2024 20:24
@jhodapp jhodapp merged commit f0e3bb0 into main Oct 5, 2024
1 check passed
@jhodapp jhodapp deleted the add_coaching_session_title branch October 5, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves existing functionality or feature feature work Specifically implementing a new feature
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants