Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several coaching session page UI cleanup changes #40

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

jhodapp
Copy link
Member

@jhodapp jhodapp commented Oct 10, 2024

Description

This PR makes several changes to the coaching-session page, main-nav, main-nav-menu and site-header.

GitHub Issue: None

Changes

  • Make the main-nav in site-header justify left as a flex box instead of as a centered container
  • Use siteConfig properties in the main-nav and main-nav-menu instead of hard coded text
  • Remove models-selector and temperature-selector components which came from the original template and are not used

Screenshots / Videos Showing UI Changes (if applicable)

Jim __ Caleb _ Oct 7_ 2024

Testing Strategy

None

Concerns

None

@jhodapp jhodapp added the enhancement Improves existing functionality or feature label Oct 10, 2024
@jhodapp jhodapp self-assigned this Oct 10, 2024
Copy link
Member Author

@jhodapp jhodapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-approving these smaller PRs while David is occupied this week.

@jhodapp jhodapp merged commit 7376c9f into main Oct 10, 2024
1 check passed
@jhodapp jhodapp deleted the misc_coaching_page_ui_enhancements branch October 10, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves existing functionality or feature
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

1 participant