Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dashboard & coaching session page data fetching and caching #56

Merged
merged 16 commits into from
Dec 23, 2024

Conversation

jhodapp
Copy link
Member

@jhodapp jhodapp commented Dec 23, 2024

Description

This PR makes a significant jump in terms of the maturity of the pattern of fetching and caching backend entity data on the frontend client side.

It now uses SWR for most entity fetching (still using Axios for the actual fetch).

It also updates to use React@19 and Next@15.

Note: it's a bit of a large PR, but it's really not that complex. The same pattern is repeated for each major entity type.

GitHub Issue: none

Changes

  • Replaces AppStateStore with OrganizationStateStore, CoachingRelationshipStateStore, CoachingSessionStateStore
  • Uses SWR for a much cleaner data fetch layering with components, many fewer useEffect uses
  • Updates to React@19
  • Updates to Next@15

Screenshots / Videos Showing UI Changes (if applicable)

N/A

Testing Strategy

  1. Login and run through every bit of functionality
  2. Make sure everything behaves exactly the same as on main branch

Concerns

None

@jhodapp jhodapp added the enhancement Improves existing functionality or feature label Dec 23, 2024
@jhodapp jhodapp added this to the 1.0-rc2 milestone Dec 23, 2024
@jhodapp jhodapp requested review from qafui and calebbourg December 23, 2024 06:28
@jhodapp jhodapp self-assigned this Dec 23, 2024
@jhodapp jhodapp merged commit 60fd0af into main Dec 23, 2024
1 check passed
@jhodapp jhodapp deleted the improve_dashboard_data_fetching_and_caching branch December 23, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves existing functionality or feature
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants