Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the size/styling of the CoachingSessionSelector and SelectCoachingSession components #61

Merged
merged 2 commits into from
Jan 5, 2025

Conversation

jhodapp
Copy link
Member

@jhodapp jhodapp commented Jan 4, 2025

Description

This PR improves the size/styling of the CoachingSessionSelector and SelectCoachingSession components with better padding, text truncation and dedupe repetitive TSX code.

GitHub Issue: None

Changes

  • Improves padding (vertically and on the right side)
  • Ensures the CoachingSessionSelector never grows larger on the right side than its parent Card container component
  • Truncates SelectItem text in a responsive way
  • Dedupes repetitive SelectItem TSX code down into a single source

Screenshots / Videos Showing UI Changes (if applicable)

Screenshot 2025-01-04 at 15 17 25

Testing Strategy

  1. Visit the Dashboard page and play with the size of the browser window (horizontal size)
  2. Observe that the coaching session selector truncates text and the select item never grows larger than the container Card component
  3. Also observe this same behavior within the coaching session page.

Concerns

  1. Truncation of SelectItem text is not perfect and I'm not sure why yet. Nonetheless, this is a huge improvement and hopefully we can figure out perfect text truncation in the future.

…chingSession components with better padding, text truncation and dedupe repetitive TSX code
@jhodapp jhodapp added the enhancement Improves existing functionality or feature label Jan 4, 2025
@jhodapp jhodapp added this to the 1.0-rc2 milestone Jan 4, 2025
@jhodapp jhodapp requested a review from qafui January 4, 2025 21:24
@jhodapp jhodapp self-assigned this Jan 4, 2025
@jhodapp jhodapp changed the title Improve the size/styling of the CoachingSessionSelector and SelectCoa… Improve the size/styling of the CoachingSessionSelector and SelectCoachingSession components Jan 4, 2025
Copy link
Collaborator

@qafui qafui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jhodapp jhodapp merged commit a5119fb into main Jan 5, 2025
4 checks passed
@jhodapp jhodapp deleted the fix_dashboard_selector_sizing_and_styling branch January 5, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves existing functionality or feature
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants