Skip to content

Fix up updating an OverarchingGoal entity #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Conversation

jhodapp
Copy link
Member

@jhodapp jhodapp commented Oct 8, 2024

Description

This PR ensures that updating an existing OverarchingGoal entity works correctly.

Note: pairs with this frontend PR.

GitHub Issue: None

Changes

  • Fix up updating an existing OverarchingGoal entity in the DB
  • Use error!() for printing our error types to the console
  • Add the inner error reason to the console for better debugging context

Testing Strategy

  1. Add an OverarchingGoal using RAPIdoc or the frontend
  2. Change the OverarchingGoal in some way and use the PUT endpoint for OverarchingGoal (or the frontend UI) to commit the updates to the DB
  3. Inspect the OverarchingGoal in the overarching_goals DB table to validate that it's been updated as expect

Concerns

None

…rror context that gets printed to the console.
@jhodapp jhodapp added the enhancement Improves existing functionality or feature label Oct 8, 2024
@jhodapp jhodapp self-assigned this Oct 8, 2024
@jhodapp jhodapp merged commit 3d84041 into main Oct 9, 2024
4 checks passed
@jhodapp jhodapp deleted the tweak_overarching_goals branch October 9, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves existing functionality or feature
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants