CI fixes [2024-07] #723
Merged
CI fixes [2024-07] #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safety started to complain about CVE-2019-8341 in jinja. The validity of the CVE is widely disputed, and in any case it is not exploitable here, so add it to the ignored list.
With respect to the CurrentMessage.get_current_message() function from dramatiq middleware, either mypy or relevant type hints have become more accurate and now reflect that the function is allowed to return None when no message is being handled (the return type now being "Message[Any] | None"). It is a precondition of this code that a message is being handled (via actor invocation). Add asserts to this effect, which will let mypy rule out the None case.
crungehottman
approved these changes
Jul 22, 2024
negillett
approved these changes
Jul 22, 2024
negillett
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix up a couple of issues which had caused CI to become blocked: