Skip to content

fix: use the permissions & environment for PyPI - #154

Merged
JAVGan merged 1 commit into
mainfrom
pypi-fix
Jul 20, 2026
Merged

fix: use the permissions & environment for PyPI#154
JAVGan merged 1 commit into
mainfrom
pypi-fix

Conversation

@JAVGan

@JAVGan JAVGan commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Fix the release action to use the missing environment and permissions to push to PyPI

Summary by Sourcery

Configure the release workflow to use the PyPI environment with appropriate permissions for deployments.

CI:

  • Grant OIDC id-token write permissions to the release job in the GitHub Actions workflow.
  • Associate the release job with the PyPI environment to enable publishing.

Fix the release action to use the missing environment and permissions to
push to PyPI

Signed-off-by: Jonathan Gangi <jgangi@redhat.com>
@sourcery-ai

sourcery-ai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Configure the release GitHub Action to use the proper environment and OIDC permissions required to publish to PyPI.

File-Level Changes

Change Details Files
Configure the deploy job in the release workflow with OIDC permissions and the PyPI environment so the action can authenticate and publish to PyPI.
  • Add id-token: write to the deploy job permissions to enable OIDC-based authentication for publishing.
  • Set environment: pypi on the deploy job so it uses the correct protected environment and associated secrets.
.github/workflows/release.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@JAVGan

JAVGan commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator Author

@lslebodn @ashwgit PTAL

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lslebodn lslebodn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JAVGan
JAVGan merged commit 493b755 into main Jul 20, 2026
22 checks passed
@JAVGan
JAVGan deleted the pypi-fix branch July 20, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants