Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS: Allow using "snapshot_accouts" from StArMap #97

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JAVGan
Copy link
Collaborator

@JAVGan JAVGan commented Feb 3, 2025

This commit updates the push command to include the snapshot_accounts property from StArMap (whenever avaialble) to be used in the _push_upload method.

Refers to RHELDST-29388

This commit updates the `push` command to include the
`snapshot_accounts` property from StArMap (whenever avaialble) to be
used in the `_push_upload` method.

Refers to RHELDST-29388
@JAVGan
Copy link
Collaborator Author

JAVGan commented Feb 3, 2025

@lslebodn @jajreidy PTAL.

It should be a one line change, but I believe there's a new property for AWS on pushsource named "opener" which had to be included in the logs to pass the CI, alongside the fix from the new black version

@@ -215,6 +215,7 @@ def _push_upload(
pi,
custom_tags=mapped_item.get_tags_for_marketplace(marketplace),
accounts=meta.get("sharing_accounts", []),
snapshot_accounts=meta.get("snapshot_accounts", []),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JAVGan I though we need tit for community workflow and not for stratosphere
and looks like we already have it in the community workflow

But related slack discussion is still in my TODO list.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I thought we would need it for the stratosphere workflow as well... Do you still think it makes sense to include it on such workflow? Or is it better to close the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants