Use pubtools namespace to resolve init file conflict [RHELDST-17607] #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amcmahon-rh
force-pushed
the
RHELDST-17607
branch
2 times, most recently
from
30b1e21 to
7a5cfef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #224 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 47 46 -1
Lines 3225 3224 -1
=========================================
- Hits 3225 3224 -1 ☔ View full report in Codecov by Sentry. |
amcmahon-rh
force-pushed
the
RHELDST-17607
branch
from
7a5cfef to
9ccd9d0
Compare
Currently, there's an issue with packaging where most of the pubtool-<lib> projects contains __init__.py and other stuff which is supposed to belong only to pubtools. Python namespaces are a convenient way to work around this issue.
amcmahon-rh
force-pushed
the
RHELDST-17607
branch
from
9ccd9d0 to
bfaa3eb
Compare
rbikar
approved these changes
May 30, 2024
rajulkumar
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there's an issue with packaging where most of the pubtool- projects contains init.py and other stuff which is supposed to belong only to pubtools. Python namespaces are a convenient way to work around this issue.
This is the only pubtools project that still has RPMs built. Since the find_namespace_packages function is not available on brew, we needed to find a work around, courtesy of Michal