-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds to AMI Access Endpoint URL used for aws marketplace #463
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -173,6 +173,18 @@ definitions: | |
minimum: 0 | ||
maximum: 65536 | ||
|
||
access_endpoint_url: | ||
type: | ||
- object | ||
- "null" | ||
properties: | ||
port: | ||
type: number | ||
minimum: 0 | ||
maximum: 65536 | ||
protocol: | ||
enum: ["http", "https"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Did you confirm the supported types are just these in some docs? Or are we just following the logic here as the endpoint must be a web one? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I checked via the WebUI when creating a version. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Related to my other comment about "scheme" vs "protocol", does this follow some existing API which uses "protocol"? |
||
|
||
required: | ||
- release | ||
- region | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: I'm not sure if you are copying some existing AWS API which already uses the term "protocol". If so, ignore this.
But in the context of a URL, this part of a URL is referred to as a "scheme", not "protocol". For example the named tuple returned by https://docs.python.org/3/library/urllib.parse.html uses "scheme". Given that this class also represents a URL, it would be nice to be consistent with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's part of the create changeset for product versions. They still don't have a doc showing all possible inputs for it in Boto3. So we're kinda left checking their own API inputs and going from there.