Fix importing version from importlib.metadata for py<3.8 #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
importlib.metadata is available for py3.8 and later versions. This fails for py<3.8, however, it could be imported from importlib_metadata for previous versions. This patch makes it compatible for py<3.8 as the lib is used on RHEL/UBI8 with py3.6.
rajulkumar
requested review from
rohanpm,
rbikar and
chandwanitulsi
as code owners
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #466 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 53 53
Lines 2351 2352 +1
=========================================
+ Hits 2351 2352 +1 ☔ View full report in Codecov by Sentry. |
rohanpm
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
importlib.metadata is available for py3.8 and later versions. This fails for py<3.8, however, it could be imported from importlib_metadata for previous versions. This patch makes it compatible for py<3.8 as the lib is used on RHEL/UBI8 with py3.6.